fixes #380 | fixes get_filter_changes() function #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ncitron can you review pls? |
|
Sorry we were working on some big changes to Helios so this will need to be redone against the current master. Looks like the bug is still there though. Good catch! The location of that file is now in |
|
Yes sure I'll update the PR |
18aaddy
force-pushed
the
fix/client-get-filter-changes
branch
from
f586d44 to
65397b7
Compare
|
✅ Rebased this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #380
I have updated the function to return correct value and call the correct function.
Working locally ✅